rpc: increase websocket frame size (again) #26967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes capturing large block receipts and traces. in this case, the traces for block 3804216.
|
I think 128 MB is too much as a default. Do you require this limit to be set on the client only? We could make it configurable... |
|
Configurable is ideal, I was just going for minimum delta. |
fjl
changed the title
|
Yep bumping it twice indicates the need for making it configurable imo. Could you create a |
|
Seeems abandoned, closing this. Feel free to reopen with the suggested changes! |
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes capturing large block receipts and traces. in this case, the traces for block 3804216. see all the create internal txs (traces) here https://etherscan.io/txsInternal?block=3804216
Previous PR: #26883 increased from 15 to 32 (to match Erigon).
This change to 128 is sufficient to fetch traces for all 16.8 million blocks of Ethereum.