Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: refactor trie API #26995

Merged
merged 4 commits into from
Apr 20, 2023
Merged

all: refactor trie API #26995

merged 4 commits into from
Apr 20, 2023

Commits on Apr 15, 2023

  1. all: refactor trie API 

    In this PR, all TryXXX(e.g. TryGet) APIs of trie are renamed to
XXX(e.g. Get) with an error returned.

The original XXX(e.g. Get) APIs are renamed to MustXXX(e.g. MustGet)
which will panic in case any error occurs.
    @rjl493456442
    rjl493456442 committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    225e20b View commit details
    Browse the repository at this point in the history

  2. trie: print error log instead of panic directly

    @rjl493456442
    rjl493456442 committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    59d398b View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. trie: fix comment

    @rjl493456442
    rjl493456442 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    34bf467 View commit details
    Browse the repository at this point in the history

  2. trie: minor fixes

    @rjl493456442
    rjl493456442 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    5493e55 View commit details
    Browse the repository at this point in the history