Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event: include Feed type fixation logic in f.init #27249

Merged
merged 3 commits into from
May 30, 2023
Merged

Conversation

dbadoy
Copy link
Contributor

@dbadoy dbadoy commented May 11, 2023

It seems make sense to include etype initialization logic in the 'init'.
What do you think?

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change to me

@fjl fjl added this to the 1.11.7 milestone May 23, 2023
@holiman holiman modified the milestones: 1.12.0, 1.12.1 May 25, 2023
@fjl fjl merged commit 8013a49 into ethereum:master May 30, 2023
shampoobera pushed a commit to berachain/polaris-geth that referenced this pull request May 30, 2023
This is a minor optimization/refactoring of Feed.

---------

Co-authored-by: Felix Lange <fjl@twurst.com>
@dbadoy dbadoy deleted the syntx branch May 30, 2023 16:35
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
This is a minor optimization/refactoring of Feed.

---------

Co-authored-by: Felix Lange <fjl@twurst.com>
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 29, 2024
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants