all: track state changes in state db #27349
Conversation
rjl493456442
force-pushed
the
value-diff
branch
2 times, most recently
from
f6da10e
to
c40c8a0
Compare
rjl493456442
force-pushed
the
value-diff
branch
7 times, most recently
from
c1cd59d
to
bad3103
Compare
rjl493456442
changed the title
rjl493456442
requested review from
zsfelfoldi,
karalabe and
holiman
as code owners
rjl493456442
force-pushed
the
value-diff
branch
7 times, most recently
from
11b2c40
to
11e25f7
Compare
| if ch.prevAccountOriginExist { | ||
| s.accountsOrigin[ch.prev.addrHash] = ch.prevAccountOrigin | ||
| } |
There was a problem hiding this comment.
We should document, somewhere, what this means. For example, if prevAccountOriginExist is true, can prevAccountOrigin be nil? And what kind of scenario would lead to that?
Simiarly, can prevAccountOriginExist be false and prevAccountOrigin be non-nil? If so, how?
And if they're both 'strongly' tied to eachother, do we really need prevAccountOriginExist?
There was a problem hiding this comment.
It's possible that prevAccountOriginExist is true and prevAccountOrigin is nil.
nil means the account was not present and it's created in this block. If we want
to reset this block, we need the explicit flag to distinguish:
- accountOrigin is nil
- accountOrigin is not existent
Regarding prevAccountOriginExist is false while prevAccountOrigin is non-nil, it's an impossible combo.
| if _, ok := s.accounts[addrHash]; ok { | ||
| s.accountsOrigin[addrHash] = nil // case (b) | ||
| } | ||
| continue |
rjl493456442
force-pushed
the
value-diff
branch
2 times, most recently
from
d273dc4
to
d9926e3
Compare
| address: s.address, | ||
| addrHash: s.addrHash, | ||
| origin: s.origin, | ||
| data: s.data, |
There was a problem hiding this comment.
I think this only deep copies the pointer to s.data, I'm not sure if this is what you want
There was a problem hiding this comment.
s.data is a struct, it's ok to directly copy it.
Re s.origin, seems we will never change the content of origin via pointer, it's also OK to copy the pointer.
This change makes the StateDB track the state key value diff of a block transition. We already tracked current account and storage values for the purpose of updating the state snapshot. With this PR, we now also track the original (pre-transition) values of accounts and storage slots.
This reverts commit 5b3e45b.
This reverts commit 5b3e45b.
| state.accounts = copyAccounts(s.accounts) | ||
| state.storages = copyStorages(s.storages) | ||
| state.accountsOrigin = copyAccounts(state.accountsOrigin) | ||
| state.storagesOrigin = copyStorages(state.storagesOrigin) |
This PR tracks the state changes in statedb.
The change set can be used to build the state history in path-based storage scheme
for state rollback and archive state serving.