-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/ethapi: eth_simulateV1 #27720
Conversation
There's no reason to have a multicall interface. Either you can have one call do the multicalls or you can use batch jsonrpc. Please reject this PR. |
No.
I believe you're referring to https://github.com/mds1/multicall. You're not able to set |
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
I've seen this test fail locally and on CI. But only every once in a while. Which is confusing for me because there is no concurrent element here. I expected any failure to be persistent.
The difference is 12 used gas. |
I have updated the flaky test to use a fixed address instead of random. My hunch is that it was sometimes reporting a different gas used because the random address could have had a 0 in the beginning resulting in a different txdata cost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged in master. It was a clean merge 👍 |
This PR needs to be re-merged with master, following the state reader merge. I could've rebased it for you, but I know you prefer merging... :) |
This is a successor PR to #25743. This PR is based on a new iteration of the spec: ethereum/execution-apis#484.
eth_multicall
takes in a list of blocks, each optionally overriding fields like number, timestamp, etc. of a base block. Each block can include calls. At each block users can override the state. There are extra features, such as:Breaking changes
This PR includes the following breaking changes:
coinbase
->feeRecipient
random
->prevRandao
baseFee
->baseFeePerGas