Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: ethSendTransaction check baseFee #27834

Merged
merged 16 commits into from
Dec 18, 2023
Merged

internal/ethapi: ethSendTransaction check baseFee #27834

merged 16 commits into from
Dec 18, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Aug 1, 2023 •
edited
Loading

This is a similar issue to #27833, but this is for the eth_sendTransaction RPC.

When I send the transaction with

  • gasPrice=1 => failed ❌
  • gasPrice=0 => success 🆗
image

After some dig, and talking with @rjl493456442 found the issue occurred by estimateGas,

the stack trace as below:

image

So when I call estimateGas, I distinguish between a call from eth_call or submitted transaction

jsvisa added 4 commits August 1, 2023 21:27
@jsvisa
internal/ethapi: distinguish Call and Transaction nobasefee check
eeaaeb2 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
graphql: estimateGas nobasefee
f067656 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: api EstimateGas noBaseFee
21dffcb 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: add document for DoEstimateGas
aa47d01 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa requested a review from s1na as a code owner August 1, 2023 16:00
holiman
holiman reviewed Aug 2, 2023
View reviewed changes
internal/ethapi/api.go Outdated Show resolved Hide resolved
@rjl493456442
Copy link
Member

rjl493456442 commented Aug 2, 2023 •
edited
Loading

I think the main issue is that we allow zero price transactions from RPC, these transactions
are invalid if 1559 is activated. We can add the check in an alternative approach:

  • if the 1559 is activated
  • reject the 0 price tx in the rpc level

This check can be done https://github.com/ethereum/go-ethereum/blob/master/internal/ethapi/transaction_args.go#L135

@holiman
Copy link
Contributor

holiman commented Aug 2, 2023

Some historic background: #23027

jsvisa added 5 commits August 3, 2023 14:05
@jsvisa
Revert "internal/ethapi: add document for DoEstimateGas"
a237e35 
This reverts commit aa47d01.

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Revert "internal/ethapi: api EstimateGas noBaseFee"
70ab508 
This reverts commit 21dffcb.

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Revert "graphql: estimateGas nobasefee"
e460555 
This reverts commit f067656.

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Revert "internal/ethapi: distinguish Call and Transaction nobasefee c…
124665e 
…heck"

This reverts commit eeaaeb2.

Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: check zero gasPrice after London
cd92b3f 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
Copy link
Contributor Author

jsvisa commented Aug 3, 2023

@rjl493456442 @holiman please take another look, I changed to check the gasPrice zeroable after London only.

jsvisa added 3 commits August 3, 2023 14:26
@jsvisa
internal/ethapi: add testcase for after London zero price
4f9cbd8 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: check gasPrice >0
1ae7845 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
internal/ethapi: add testcase of pre-london
afd4217 
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa added 2 commits August 3, 2023 16:47
@jsvisa
internal/ethapi: review fix
9120fa2 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
add eip1559 zero check too
d59298f 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa jsvisa requested a review from holiman August 15, 2023 17:45
@rjl493456442 rjl493456442 mentioned this pull request Aug 21, 2023
Closed
@jsvisa
internal/ethapi: test case error msg
ef96ce1 
Signed-off-by: jsvisa <delweng@gmail.com>
@holiman holiman modified the milestone: 1.13.6 Dec 18, 2023
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
72ecc6b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
57f6ddb
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
8fd1d1d
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
241b2b2
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
dbc5eff
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
c5301db
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
1e79298
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
42fac60
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
463ecc7
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
89d39f9
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
6ff5d55
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
29945bd
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
07d68d2
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
01d8166
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
eaa8755
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
262a26c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
48ab8f2
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
1e35bc0
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
c7c78b5
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
9c6fe6c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
e9f527a
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
a80ff45
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
f8ee03b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
b49e060
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
0010c8a
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
928eacf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
5d9b288
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
10f7cfc
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@gzliudan
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
0237985
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
@gzliudan @wanwiset25
internal/ethapi: ethSendTransaction check baseFee (ethereum#27834)
226c3cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjl493456442 rjl493456442 rjl493456442 approved these changes

@fjl fjl fjl approved these changes

@s1na s1na Awaiting requested review from s1na s1na is a code owner

@holiman holiman Awaiting requested review from holiman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.7
Development

Successfully merging this pull request may close these issues.
4 participants
@jsvisa @rjl493456442 @holiman @fjl