Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: compact db missing key starts with 0xff #28207

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Sep 26, 2023

No description provided.

Signed-off-by: jsvisa <delweng@gmail.com>
@rjl493456442
Copy link
Member

Could you please provide more details regarding the rationale behind this pull request?

Btw, the compact boundary is already handled here https://github.com/ethereum/go-ethereum/blob/master/ethdb/pebble/pebble.go#L394

@jsvisa
Copy link
Contributor Author

jsvisa commented Sep 27, 2023

As the old for loop for b := byte(0); b < 255; b++ { will only iterate the keys from (0x00, 0x01) to (0xfe, 0xff), so the keys after 0xff were not compacted.

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.13.3 milestone Sep 28, 2023
@karalabe karalabe merged commit 46c850a into ethereum:master Sep 28, 2023
1 check passed
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 12, 2023
tyler-smith pushed a commit to blocknative/go-ethereum that referenced this pull request Oct 16, 2023
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants