-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd, eth: switch the dev synctarget to hash from block #28209
Merged
Merged
+126
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
requested review from
gballet,
holiman and
rjl493456442
as code owners
September 27, 2023 11:34
Cool
|
Erm, what's with snap sync in there? cc @rjl493456442 |
Ah ok, it's unrelated to any changes. The original synctarget code required --syncmode=full. I just dropped that requirement and defaulted to it, but the node thinks it's snap syncing until done. Lemme see if I can hard swap the sync-flag out to full. |
karalabe
force-pushed
the
synctarget-hash
branch
from
September 28, 2023 10:09
e083530
to
619649d
Compare
@holiman PTAL |
hyunchel
pushed a commit
to hyunchel/go-ethereum
that referenced
this pull request
Oct 6, 2023
* cmd, eth: switch the dev synctarget to hash from block * cmd/utils, eth/catalyst: terminate node wyen synctarget reached
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 12, 2023
* cmd, eth: switch the dev synctarget to hash from block * cmd/utils, eth/catalyst: terminate node wyen synctarget reached
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 16, 2023
* cmd, eth: switch the dev synctarget to hash from block * cmd/utils, eth/catalyst: terminate node wyen synctarget reached
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
* cmd, eth: switch the dev synctarget to hash from block * cmd/utils, eth/catalyst: terminate node wyen synctarget reached
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…eum#28209)" This reverts commit f754753.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
…eum#28209)" This reverts commit f754753.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switched the
--synctarget
flag from requiring a block RLP in a file (which is annoyingly hard to obtain) to just using a hash and retrieving everything else from the network.geth --synctarget 0x91c90676cab257a59cd956d7cb0bceb9b1a71d79755c23c7277a0697ccfaf8c4