common: remove address.Hash footgun #28228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunchel
pushed a commit
to hyunchel/go-ethereum
that referenced
this pull request
Oct 6, 2023
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 12, 2023
tyler-smith
pushed a commit
to blocknative/go-ethereum
that referenced
this pull request
Oct 16, 2023
|
I noticed this breaking change when I upgraded the package, and maybe marking the function as 
|
|
+1 here, I got hit with some errors after upgrading the Rocket Pool stack dependencies because this function doesn't exist anymore. It was easy enough to find the old source and migrate to |
devopsbo3
pushed a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 4502642.
devopsbo3
added a commit
to HorizenOfficial/go-ethereum
that referenced
this pull request
Nov 10, 2023
This reverts commit 4502642.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.