Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/blake2b: only fuzz non-generic functions if enabled #28381

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

MariusVanDerWijden
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden commented Oct 19, 2023

This PR tries to unbork master by only enabling the fuzzer if non-generic functions can be accessed (which is not the case on 32-bit platforms)

@MariusVanDerWijden
Copy link
Member Author

Works on my local oss-fuzz build

Comment on lines +2 to +3
//go:build go1.7 && amd64 && !gccgo && !appengine
// +build go1.7,amd64,!gccgo,!appengine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//go:build go1.7 && amd64 && gc && !purego

appengine is obsolete and superseded by purego, and gc is a more
precise tag for files that use gc-syntax assembly.

Source https://cs.opensource.google/go/x/crypto/+/be400aefbc4c83e9aab51e82b8d4b12760653b47 via https://cs.opensource.google/go/x/crypto/+/master:blake2b/;bpv=1

But IMO it's fine to leave it as is, so it uses the exact same logic as the other files in this package

Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me

@holiman holiman added this to the 1.13.5 milestone Oct 19, 2023
@holiman holiman merged commit cd29535 into ethereum:master Oct 19, 2023
1 check passed
devopsbo3 pushed a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
…thereum#28381)

This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
devopsbo3 added a commit to HorizenOfficial/go-ethereum that referenced this pull request Nov 10, 2023
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
…thereum#28381)

This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Nov 29, 2024
…thereum#28381)

This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Nov 29, 2024
…thereum#28381)

This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Nov 29, 2024
…thereum#28381)

This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 2, 2024
…thereum#28381)

This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 2, 2024
…thereum#28381)

This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 4, 2024
…thereum#28381)

This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Dec 9, 2024
…thereum#28381)

This change to fixes a compilation-flaw on master, by putting architecture-specific functions behind corresponding build tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants