Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethclient: apply accessList field in toCallArg #28832

Merged
merged 3 commits into from
Jan 19, 2024
Merged

ethclient: apply accessList field in toCallArg #28832

merged 3 commits into from
Jan 19, 2024

Conversation

colinlyguo
Copy link
Contributor

@colinlyguo colinlyguo commented Jan 18, 2024 •
edited
Loading

This PR aims to add support for the accessList field in the eth_call and eth_estimateGas Ethereum JSON-RPC methods. According to the JSON-RPC specification, the input parameter named Transaction for both eth_call and eth_estimateGas is $ref: '#/components/schemas/GenericTransaction', which can include the accessList field.

ref:
eth_call: https://github.com/ethereum/execution-apis/blob/main/src/eth/execute.yaml#L7
eth_estimateGas: https://github.com/ethereum/execution-apis/blob/main/src/eth/execute.yaml#L22
accessList in GenericTransaction: https://github.com/ethereum/execution-apis/blob/main/src/schemas/transaction.yaml#L404

fjl
fjl reviewed Jan 19, 2024
View reviewed changes
ethclient/ethclient.go Outdated Show resolved Hide resolved
@fjl fjl changed the title feat: add accessList field in toCallArg ethclient: apply accessList field in toCallArg Jan 19, 2024
@fjl fjl added this to the 1.13.11 milestone Jan 19, 2024
@fjl fjl merged commit 1c48829 into ethereum:master Jan 19, 2024
2 of 3 checks passed
Dergarcon pushed a commit to specialmechanisms/mev-geth-0x2mev that referenced this pull request Jan 31, 2024
@colinlyguo @fjl @Dergarcon
ethclient: apply accessList field in toCallArg (ethereum#28832)
977c195 
Co-authored-by: Felix Lange <fjl@twurst.com>
@gzliudan gzliudan mentioned this pull request May 17, 2024
Merged
19 tasks
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
eab2bc5 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
7f6c993 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
8b1a6a8 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
12a9573 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 10, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
2ad1d2c 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
2324858 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
a7d2064 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
3ea02fd 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
7ff660c 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
8f0081c 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
2087076 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
094f52c 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
6b79e76 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
a5a8072 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
67bc85d 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 23, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
a52efce 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
8427fa6 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
4798194 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
3c804eb 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 9, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
fd0d626 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 17, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
4ba5abc 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 18, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
4552f24 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
c1c8ee9 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 25, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
d052a67 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 29, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
ea39358 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 30, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
737bdbc 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
6eae7cc 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Oct 31, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
e1dd899 
Co-authored-by: Felix Lange <fjl@twurst.com>
gzliudan pushed a commit to gzliudan/XDPoSChain that referenced this pull request Nov 1, 2024
@colinlyguo @fjl @gzliudan
ethclient: apply accessList field in toCallArg (ethereum#28832)
bb55c10 
Co-authored-by: Felix Lange <fjl@twurst.com>
wanwiset25 pushed a commit to XinFinOrg/XDPoSChain that referenced this pull request Nov 13, 2024
@colinlyguo @fjl @wanwiset25
ethclient: apply accessList field in toCallArg (ethereum#28832)
6bec563 
Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl fjl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.11
Development

Successfully merging this pull request may close these issues.
2 participants
@colinlyguo @fjl