-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accounts/usbwallet: use go-hidapi #28901
Conversation
go.mod
Outdated
go 1.21 | ||
|
||
toolchain go1.21.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My ide started shoving this in there. No idea why.
I verified that Ledger X and Ledger S works on mac. |
Building with this PR requires |
On my
EDIT: I was using the wrong binary. Solved, all works perfectly! |
|
Tagging for triage,
|
Closing in favour of #28945 |
Instead of updating
hidapi
withinkaralabe/usb
in karalabe/usb#43, this might be an alternative: use a hidapi-only library from go-ethereum.Todo tests:
Nano X
,Nano S
,Nano S Plus
)