Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: update execution spec tests + split statetest exec #28993

Merged
merged 1 commit into from
Feb 15, 2024
Merged

tests: update execution spec tests + split statetest exec #28993

merged 1 commit into from
Feb 15, 2024
+104 −75

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Feb 15, 2024 •
edited
Loading

This PR does two things:

  • it brings up the execution spec tests to latest release, 2.1.0
    • The execution spec tests previously were only blockchain tests, but now also contain statetests.
    • These statetests are now also executed, in TestExecutionSpecState
  • it moves legacy state tests into TestLegacyState

With this PR, about 25% of TestState is instead shoved off into TestLegacyState:

[user@work go-ethereum]$ go test ./tests -run TestLegacyState
ok      github.com/ethereum/go-ethereum/tests   58.864s
[user@work go-ethereum]$ go test ./tests -run TestState
ok      github.com/ethereum/go-ethereum/tests   180.807s

This is good, because the test timeout is per individual test, afaik, so cutting off 30% should bring us safely below the 20m limit on appveyor again.

MariusVanDerWijden
MariusVanDerWijden approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@MariusVanDerWijden MariusVanDerWijden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holiman holiman added this to the 1.13.13 milestone Feb 15, 2024
@holiman holiman merged commit 886f0e7 into ethereum:master Feb 15, 2024
3 checks passed
@holiman holiman mentioned this pull request Feb 15, 2024
Merged
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
@holiman @jorgemmsilva
tests: update execution spec tests + split statetest exec (ethereum#2…
df80428 
…8993)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariusVanDerWijden MariusVanDerWijden MariusVanDerWijden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.13
Development

Successfully merging this pull request may close these issues.
2 participants
@holiman @MariusVanDerWijden