trie: preallocate capacity for fields slice #29614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -78,7 +78,7 @@ func NewNodeSet(owner common.Hash) *NodeSet { | |||
| // ForEachWithOrder iterates the nodes with the order from bottom to top, | |||
| // right to left, nodes with the longest path will be iterated first. | |||
| func (set *NodeSet) ForEachWithOrder(callback func(path string, n *Node)) { | |||
| var paths []string | |||
| paths := make([]string, 0, len(set.Nodes)) | |||
There was a problem hiding this comment.
It could be useful. As normally we have thousands of dirty nodes in each block, could be beneficial in hash-based scheme.
rjl493456442
approved these changes
Apr 23, 2024
holiman
changed the title
jorgemmsilva
pushed a commit
to iotaledger/go-ethereum
that referenced
this pull request
Jun 17, 2024
trie: Preallocate capacity for fields slice
stwiname
pushed a commit
to subquery/data-node-go-ethereum
that referenced
this pull request
Sep 9, 2024
trie: Preallocate capacity for fields slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids multiple memory allocations and array resizing when appending elements, making the code more efficient.