Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trie/trienode: minor speedup in nodeset merging #29683

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Apr 30, 2024

Shaves off a bit of alloc during nodes merge

name         old time/op    new time/op    delta
Merge/1K-8      600µs ± 7%     544µs ± 4%   -9.26%  (p=0.000 n=9+10)
Merge/10K-8    5.99ms ± 8%    5.48ms ± 7%   -8.64%  (p=0.000 n=10+10)

name         old alloc/op   new alloc/op   delta
Merge/1K-8      252kB ± 0%     244kB ± 0%   -3.17%  (p=0.000 n=8+10)
Merge/10K-8    2.02MB ± 0%    1.94MB ± 0%   -3.96%  (p=0.000 n=10+10)

name         old allocs/op  new allocs/op  delta
Merge/1K-8      2.08k ± 0%     0.08k ± 0%  -96.29%  (p=0.000 n=10+9)
Merge/10K-8     20.6k ± 0%      0.6k ± 1%  -97.31%  (p=0.000 n=10+10)

@rjl493456442 rjl493456442 added this to the 1.14.1 milestone Apr 30, 2024
@rjl493456442 rjl493456442 merged commit 242b24a into ethereum:master Apr 30, 2024
3 checks passed
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
stwiname pushed a commit to subquery/data-node-go-ethereum that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants