Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preallocated capacity for map's certain usege of memory #29690

Merged
merged 2 commits into from
May 2, 2024
Merged

preallocated capacity for map's certain usege of memory #29690

merged 2 commits into from
May 2, 2024
+1 −1

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented May 1, 2024

No description provided.

karalabe
karalabe requested changes May 2, 2024
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in the node buffer might be interesting because that's on the hot path, but the rest is really just a startup thing, so those are cleaner as is.

@mask-pp
Copy link
Contributor Author

mask-pp commented May 2, 2024

The change in the node buffer might be interesting because that's on the hot path, but the rest is really just a startup thing, so those are cleaner as is.

The change in the node buffer might be interesting because that's on the hot path, but the rest is really just a startup thing, so those are cleaner as is.

Yeah, the rest of the changes are optional, reverted the other changes.

@mask-pp mask-pp requested a review from karalabe May 2, 2024 09:32
karalabe
karalabe approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@karalabe karalabe added this to the 1.14.1 milestone May 2, 2024
@karalabe karalabe merged commit 2c67fab into ethereum:master May 2, 2024
1 of 2 checks passed
jorgemmsilva pushed a commit to iotaledger/go-ethereum that referenced this pull request Jun 17, 2024
@mask-pp @jorgemmsilva
trie/pathdb: preallocate map capacity (ethereum#29690)
474d0d8 
* preallocated capacity for map's certain usege of memory

* preallocated capacity for map's certain usege of memory
stwiname pushed a commit to subquery/data-node-go-ethereum that referenced this pull request Sep 9, 2024
@mask-pp @stwiname
trie/pathdb: preallocate map capacity (ethereum#29690)
5cf98ef 
* preallocated capacity for map's certain usege of memory

* preallocated capacity for map's certain usege of memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe approved these changes

@fjl fjl Awaiting requested review from fjl

@holiman holiman Awaiting requested review from holiman

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mask-pp @karalabe