remove all references to InsertOrdered #341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InsertOrdered
model does not work as well for the verkle conversion, as it doesn't take advantage of the per-level deserialization. This will make the process slower. It also makes things more difficult if the stateful and stateless code are to be merged: that method would have to be supported in a stateless context. Finally, it also contains a lot of duplicated code compared toInsert
, which is wasteful.This PR:
InsertOrdered
;FlushAtDepth
is used. Note that the semantics ofFlushAtDepth
are changed to also hash leaf nodes. This would make things more expensive if we were to use it for the conversion method, but this method is falling out of favor;