use UnknownNode in InternalNode to turn it into a stateless node #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
approved these changes
Apr 19, 2023
gballet
force-pushed
the
stateless-internal-nodes
branch
from
9fa8c79 to
27e4e64
Compare
* safety improvment: use Unknown instead of nil * fix tests * rename Unknown to the clearer UnknownNode * return an error in GetProofItems and forbid calling it on incomplete trees * remove unused functions
gballet
changed the title
* remove all references to stateless * remove unused error
|
It's still missing support for stateless leaf nodes. I guess this can be achieved by using the map that was introduced in #338, assuming that it remains fast enough. |
|
Note: technically using This is still a problem because e.g. the producer could cheat by charging full price for reading 0 values while not adding them to the witness. That's a problem left to a subsequent PR though. |
gballet
commented
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at getting rid of
StatlessNodein order to simplify the code and be able to use all the optimizations that were made recently, in a statless context.Currently the idea is to use
UnknownNodeto signal that a subtree of anInternalNodeis missing from the stateless view.