tree: add new method GetAndLoadForProof #383
Conversation
jsign
force-pushed
the
jsign-load-key-for-proof
branch
from
2a6d843 to
131aace
Compare
jsign
changed the title
tree.go
Outdated
| } | ||
| pe.Vals = append(pe.Vals, nil) // TODO(PR-temp): workaround proving bug. |
There was a problem hiding this comment.
Could you please move this to another PR and come up with a test that demonstrates the bug?
When you call This method does something extra needed for proof generation. When we want to generate a proof for a leaf value, we also need all the internal node children in that path. That's because we need all the evaluations of the vector in that internal node to prove the opening in internal nodes. This part of the PR code is exactly doing this (also note some code comment a few lines above). Doing all this at the Geth layer is very complicated and confusing. This API is providing a way of asking: "Load the tree for this key, and also all the auxiliary stuff that I'll need to generate a proof without any further resolving" (as you'd have with using That means that Geth can call this method for every key in the witness. After finishing with these simple calls it will know the loaded tree is fully ready to generate a proof (without a resolver or anything extra for proof generation). That's exactly the idea of the referenced Geth PR in the PR description. While the EVM is collecting accessed keys in the witness, we use this API to load in the background the needed tree with all the resolved stuff. When the EVM finishes, the Witness already has loaded all that it needs so Geth can use this tree to generate the proof. |
|
ah right of course. LGTM. |
jsign
force-pushed
the
jsign-load-key-for-proof
branch
from
56b32d7 to
de81293
Compare
proof_ipa.go
Outdated
| for i := range vp.OtherStems { | ||
| ret.OtherStems[i] = vp.OtherStems[i] | ||
| } | ||
|
|
||
| copy(ret.OtherStems, vp.OtherStems) | ||
| copy(ret.DepthExtensionPresent, vp.DepthExtensionPresent) | ||
| for i := range vp.CommitmentsByPath { | ||
| ret.CommitmentsByPath[i] = vp.CommitmentsByPath[i] | ||
| } | ||
| copy(ret.CommitmentsByPath, vp.CommitmentsByPath) |
There was a problem hiding this comment.
The new linter was complaining about this (unrelated to the PR), but it's still a good point and fixed.
jsign
force-pushed
the
jsign-load-key-for-proof
branch
from
f3de2cb to
186176e
Compare
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
force-pushed
the
jsign-load-key-for-proof
branch
from
186176e to
e0c4061
Compare
This PR adds a new helper method that will assist clients in preloading the tree for proof generation.
See gballet/go-ethereum#255