Proof of absence border case test #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
changed the base branch from
master
to
jsign-tree-reconstr-extra-checks
jsign
commented
Nov 1, 2023
| @@ -1088,3 +1088,40 @@ func TestGenerateProofWithOnlyAbsentKeys(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func TestProofOfPresenceWithEmptyValue(t *testing.T) { | |||
There was a problem hiding this comment.
This test case is pretty simple, and I believe shows a potentially fundamental flaw of the optimization done compared to the spec reference regarding "leaving out" the extension statuses for stems that have both proof of presence and absence.
The test case is simple:
- Add a key with a value.
- Prove that another key that corresponds to that
LeafNodehas valuenil.
This fails for what looks like a simple to fix bug, but after you do the obvious fix it will be apparent that that will break another test and the fundamental issue will become more apparent.
I can explain more in Matrix.
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
jsign
force-pushed
the
jsign-proof-tests
branch
from
d3dee8c to
946621d
Compare
Closed
…sence value (#414) * keep the extension statuses of absent stems Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * more improvements and tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix & extra test case Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * make steams and extStatuses be 1:1 Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * cleanup Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
gballet
pushed a commit
that referenced
this pull request
Nov 6, 2023
* proof: verify proof of absence steam is sorted Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * proof: more length checks Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * more tree from proof checks Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add checks in CreatePath Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * lints Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix comments Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Proof of absence border case test (#413) * proof: add proof of absence border case tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * Proof of absence and presence for the same path with nil proof of presence value (#414) * keep the extension statuses of absent stems Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * more improvements and tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix & extra test case Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * make steams and extStatuses be 1:1 Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * cleanup Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * lint Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * add extra border case test Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix bug Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * further fixes Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * cleanup Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra tests case that proves, what I consider, an unfortunate flaw in an optimization included a while ago ~around #188.
The explanation is that if we have a proof of absence and a proof of presence in the same leaf node, and that proof of absence is for a
nilvalue, we get in a situation in which we can't figure out the appropriatestem.