add DeleteAtStem command for state rollbacks #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsign
reviewed
Jul 24, 2024
Comment on lines
+679
to
+694
| // delete the entire child if instructed to by | ||
| // the recursive algorigthm. | ||
| if del { | ||
| n.children[nChild] = Empty{} | ||
|
|
||
| // Check if all children are gone, if so | ||
| // signal that this node should be deleted | ||
| // as well. | ||
| for _, c := range n.children { | ||
| if _, ok := c.(Empty); !ok { | ||
| return false, nil | ||
| } | ||
| } | ||
|
|
||
| return true, nil | ||
| } |
There was a problem hiding this comment.
I know this is a copy/paste from the Delete(...) API, but I guess we could try extracting the logic to a private method?
And BTW, there's a typo (that already existed before). L680, "algorigthm"
There was a problem hiding this comment.
I tried to do that right off the bat, but it's making the interface more complicated. I'd like to do that too, but I want to ensure correctness.
One of the differences, as you pointed out, is what happens when you delete something that doesn't exist. Since this is meant to be called from something that knows of reverse-diffs, so if the value does not exist, there is an issue somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method to delete a whole subgroup instead of individual keys. This is necessary for a more efficient deletion of an account when doing a rollback, which is used by the PBSS archive node.
TODO