Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove replay workflow #450

Merged
merged 3 commits into from
Aug 29, 2024
Merged

ci: remove replay workflow #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7295a34
ci: remove replay
jsign Aug 28, 2024
c8209e5
readme: cleanup
jsign Aug 28, 2024
d28d2ef
lints
jsign Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 0 additions & 61 deletions .github/workflows/block_replay.yml
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
[![Go Version](https://img.shields.io/badge/go-v1.19-green.svg)](https://golang.org/dl/)
[![Lint and Test](https://github.com/ethereum/go-verkle/actions/workflows/go.yml/badge.svg)](https://github.com/ethereum/go-verkle/actions/workflows/go.yml)
[![DeepSource](https://deepsource.io/gh/ethereum/go-verkle.svg/?label=active+issues&show_trend=true&token=OjuF5Q2HbKzpWY8LgWuffNZp)](https://deepsource.io/gh/ethereum/go-verkle/?ref=repository-badge)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gballet, it looks like this badge is broken.

Rendered README:
image

I had removed this, but if you think this is a mistake due to some misconfiguration of Deepsource or something maybe you want to check out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it seems to have been broken when we moved to the ethereum org, or maybe I just didn't accept the new permissions. I asked the org to add it back, let's see what they say.

[![goreports](https://goreportcard.com/badge/github.com/ethereum/go-verkle)](https://goreportcard.com/report/github.com/ethereum/go-verkle)
[![API Reference](https://camo.githubusercontent.com/915b7be44ada53c290eb157634330494ebe3e30a/68747470733a2f2f676f646f632e6f72672f6769746875622e636f6d2f676f6c616e672f6764646f3f7374617475732e737667)](https://pkg.go.dev/github.com/ethereum/go-verkle)
[![Block replay](https://github.com/ethereum/go-verkle/actions/workflows/block_replay.yml/badge.svg)](https://github.com/ethereum/go-verkle/actions/workflows/block_replay.yml)


# go-verkle

Expand Down
4 changes: 3 additions & 1 deletion proof_ipa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,9 @@ func Verify(vp *VerkleProof, preStateRoot []byte, postStateRoot []byte, statedif
}

rootC := new(Point)
rootC.SetBytes(preStateRoot)
if err := rootC.SetBytes(preStateRoot); err != nil {
return fmt.Errorf("error setting prestate root: %w", err)
}
pretree, err := PreStateTreeFromProof(proof, rootC)
if err != nil {
return fmt.Errorf("error rebuilding the pre-tree from proof: %w", err)
Expand Down
Loading