Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Mist localisation is not applied #945

Closed
chevdor opened this issue Jul 9, 2016 · 9 comments · Fixed by #1783
Closed

Mist localisation is not applied #945

chevdor opened this issue Jul 9, 2016 · 9 comments · Fixed by #1783

Comments

@chevdor
Copy link

chevdor commented Jul 9, 2016

Node type: geth
OS: OS X
Network type: n/a
Mist version: 0.8.0

The following applies for both running in Mist mode or in the default mode.
When choosing another language than english, I can see on OS X the menus being localised properly.
However, the wallet itself is not localised.

screen_shot_2016-07-09_at_17_09_15
screen_shot_2016-07-08_at_23_21_16

@luclu
Copy link
Contributor

luclu commented Jul 11, 2016

I can confirm this on OSX.
Might be related to #896
Pinging @alexvandesande

@alexvandesande
Copy link
Collaborator

We had to read the tap-bundler so this is still open

@luclu
Copy link
Contributor

luclu commented Sep 17, 2016

@alexvandesande this problem seems to persist with 0.8.2: #1161

@h3ll0fr13nd
Copy link
Contributor

image
This is the terminal output when changing the language from the default startup to another language using the [View]=>[Change Language] menu.

@frozeman
Copy link
Contributor

frozeman commented Feb 6, 2017

The issue here is that numeral.js doesn't support nl and therefore crashes the language switching as it seems. This happens in line https://github.com/ethereum/mist/blob/develop/interface/client/appStart.js#L85
@luclu when youre back could you take a look?

@frozeman
Copy link
Contributor

frozeman commented Feb 6, 2017

@h3ll0fr13nd does it switch the interface language for you?

@h3ll0fr13nd
Copy link
Contributor

image
It does translate the sidebar, but not the wallet; see above screenshot. numeral.language seems to expect two inputs.

@frozeman
Copy link
Contributor

frozeman commented Feb 6, 2017

Yeah the wallet doesn't get the language setting yet, we need to set this in the user agents locale and the wallet would need to react to that.

@lock
Copy link

lock bot commented Mar 31, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants