Implement EXTCODEHASH opcode for Constantinople #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgdorf
force-pushed
the
christoph/feat/extcodehash
branch
3 times, most recently
from
8258c93
to
fcea138
Compare
pipermerriam
approved these changes
Aug 7, 2018
cburgdorf
force-pushed
the
christoph/feat/extcodehash
branch
from
fcea138
to
4ac6717
Compare
carver
reviewed
Aug 17, 2018
| @@ -56,6 +56,7 @@ | |||
| GASPRICE = 0x3a | |||
| EXTCODESIZE = 0x3b | |||
| EXTCODECOPY = 0x3c | |||
| EXTCODEHASH = 0x3f | |||
There was a problem hiding this comment.
nitpick
The other opcodes are in byte order, maybe put this after RETURNDATACOPY?
There was a problem hiding this comment.
I was thinking back and forth for a minute when I wrote it but then settled with alphabetical order as that is the chosen order at most other places (e.g. in mnemonics). But now that I think about it again, would probably have made sense to use byte order here to stay consistent within this location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Missing the EXTCODEHASH opcode as specified for Constantinople (#719)
How was it fixed?
Implemented it.
Known issues
test_opcodesgot more messy as we are reusing one computation setup strategy across all tests. (though, I think it's not that bad yet)Cute Animal Picture