[Superseded by 1858] Add Istanbul block numbers to mainnet and goerli #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
force-pushed
the
istanbul-block-number
branch
from
3e82d51 to
b3c939d
Compare
Also add an explicit test with Istanbul
Raising the exception immediately tells you what's wrong if a test fails, rather than giving you a no-context assertion failure.
Istanbul increases several gas prices. The benchmark doesn't need to verify gas usage, so no need to be super-specific on the transaction's gas limit.
carver
force-pushed
the
istanbul-block-number
branch
from
b3c939d to
7be93c8
Compare
carver
changed the title
|
Trying to get a py-evm release out today |
|
cc @cburgdorf in case you have thoughts on the benchmark updates |
|
Ah, thanks @voith I'll try to use that one instead. |
carver
changed the title
2 tasks
|
Merged in #1871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes #1839
(also Goerli, which doesn't have an issue, I think)
How was it fixed?
Added numbers based on: https://eips.ethereum.org/EIPS/eip-1679
To-Do
Cute Animal Picture