Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapper for BLS python bindings in Chia Network #71

Open
mhchia opened this issue May 25, 2019 · 4 comments
Open

Wrapper for BLS python bindings in Chia Network #71

mhchia opened this issue May 25, 2019 · 4 comments

Comments

@mhchia
Copy link

mhchia commented May 25, 2019

What is wrong?

To address #66, we can make use of faster implementations. Chia-Network has BLS signature implementation in C++, as well as its bindings for Python.

How can it be fixed

To make use of the bindings, we need a wrapper for the essential functions in bls.api

  • sign
  • privtopub
  • verify
  • aggregate_signatures
  • aggregate_pubkeys
  • aggregate_multiple

Possible concerns

Chia-Network/bls-signatures is under the license Apache 2.0. From my understanding, since we only import the library, from the rules in Apache 2.0, it seems not to affect our license. Is it correct? I don't have enough experience in the licenses. Please correct me if I'm wrong.

@mhchia
Copy link
Author

mhchia commented May 25, 2019

@ChihChengLiang
Copy link
Contributor

Could we leave bls/api.py as is, and put the wrapper in somewhere like bls_binding/api.py?

For the license concern, I don't have experience in this either.

@carver
Copy link
Collaborator

carver commented May 27, 2019

Chia-Network/bls-signatures is under the license Apache 2.0. From my understanding, since we only import the library, from the rules in Apache 2.0, it seems not to affect our license. Is it correct? I don't have enough experience in the licenses. Please correct me if I'm wrong.

Yeah, no problem to add a dependency on an Apache-licensed library. It's pretty much only a problem with something like GPL-like licenses.

@mhchia
Copy link
Author

mhchia commented May 28, 2019

@carver That sounds great! Thank you for answering:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants