Merge pull request #2677 from ethereum/publish-metadata

Added Metadata Contract Name To Success Modal
ethereum · Mar 31, 2020 · f6ce838 · f6ce838
2 parents bffc543 + 4fd44cc
commit f6ce838
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js
diff --git a/src/app/ui/modal-dialog-custom.js b/src/app/ui/modal-dialog-custom.js
@@ -3,8 +3,9 @@ var yo = require('yo-yo')
 var css = require('./styles/modal-dialog-custom-styles')
 
 module.exports = {
-  alert: function (text) {
-    return modal('', yo`<div>${text}</div>`, null, { label: null })
+  alert: function (title, text) {
+    if (text) return modal(title, yo`<div>${text}</div>`, null, { label: null })
+    return modal('', yo`<div>${title}</div>`, null, { label: null })
   },
   prompt: function (title, text, inputValue, ok, cancel, focus) {
     return prompt(title, text, false, inputValue, ok, cancel, focus)

diff --git a/test-browser/tests/publishContract.js b/test-browser/tests/publishContract.js
@@ -17,7 +17,7 @@ module.exports = {
     .verifyContracts(['Ballot'])
     .click('#publishOnIpfs')
     .getModalBody((value, done) => {
-      if (value.indexOf('Metadata published successfully.') === -1) browser.assert.fail('ipfs deploy failed', '', '')
+      if (value.indexOf('Metadata of "ballot" was published successfully.') === -1) browser.assert.fail('ipfs deploy failed', '', '')
       if (value.indexOf('dweb:/ipfs') === -1) browser.assert.fail('ipfs deploy failed', '', '')
       done()
     })
@@ -28,7 +28,7 @@ module.exports = {
     browser
     .click('#publishOnSwarm')
     .getModalBody((value, done) => {
-      if (value.indexOf('Metadata published successfully.') === -1) browser.assert.fail('swarm deploy failed', '', '')
+      if (value.indexOf('Metadata of "ballot" was successfully.') === -1) browser.assert.fail('swarm deploy failed', '', '')
       if (value.indexOf('bzz') === -1) browser.assert.fail('swarm deploy failed', '', '')
       done()
     })