Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes #1523

Merged
merged 16 commits into from
Sep 18, 2018
Merged

Various fixes #1523

merged 16 commits into from
Sep 18, 2018

Conversation

yann300
Copy link
Collaborator

@yann300 yann300 commented Sep 17, 2018

  • don't clear input after sending
  • add api in terminal "getFile"
  • improve UX run tab
  • add info icon

@ryestew
Copy link
Collaborator

ryestew commented Sep 18, 2018

  • On the runtab- how is i next to Environment different from ? next to the contract pulldown? I think it should the ? without the circle is a bit clearer - fa-question and maybe at 13 or 14px. If they are basically doing the same thing - adding a bit of info & context - then they should both be an "i".

  • Were we getting some complaints about confusion between atAddress and deploy? It does make it kind of conversational and more legible to have the "or". I tried putting a line separating them instead of the "or" but it looked more distracting. So lets try the "or". Maybe add 13px of margin-top above the Deploy ( a small point):

image

For not clearing the inputs - do users generally not want the inputs cleared after submitting? I assumed clearing would be better - or is clearing better for methods in the contract and not clearing is better for the constructor?

@yann300
Copy link
Collaborator Author

yann300 commented Sep 18, 2018

On the runtab- how is i next to Environment different from ? next to the contract pulldown? I think it should the ? without the circle is a bit clearer - fa-question and maybe at 13 or 14px. If they are basically doing the same thing - adding a bit of info & context - then they should both be an "i".

right ;)

@yann300
Copy link
Collaborator Author

yann300 commented Sep 18, 2018

Were we getting some complaints about confusion between atAddress and deploy?

not really but we were discussing that point during a call a few weeks/month ago

@yann300
Copy link
Collaborator Author

yann300 commented Sep 18, 2018

For not clearing the inputs - do users generally not want the inputs cleared after submitting? I assumed clearing would be better - or is clearing better for methods in the contract and not clearing is better for the constructor?

I think there's a bug filed from an user for that (can't find the issue though), and after having tried a bit last week function / constructor execution, i think that more convenient to not clear the input. The main reason is that you often need to test the same function and you need to be able to easily copy/paste the inputs.

I think the better would be to be able to have some sort of autocompletion e.g a way to easily retrieve the inputs, so not clearing is like a "work around" for now.

@ryestew
Copy link
Collaborator

ryestew commented Sep 18, 2018

Everything looks fine - except the i seems a bit big - probably it should not have the font-size specified - as I had suggested when it was a ?. Its a very tiny detail though. We can proceed with or without this change.

@ryestew
Copy link
Collaborator

ryestew commented Sep 18, 2018

1 more comment - the spacing between the Deploy button and the or and then between the or and the AtAddress button is not the same. The Ataddress needs to have a margin-top of 6px - I think.

@yann300 yann300 merged commit b53f594 into master Sep 18, 2018
@axic axic deleted the variousFixes branch September 19, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants