-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #1523
Various fixes #1523
Conversation
yann300
commented
Sep 17, 2018
- don't clear input after sending
- add api in terminal "getFile"
- improve UX run tab
- add info icon
For not clearing the inputs - do users generally not want the inputs cleared after submitting? I assumed clearing would be better - or is clearing better for methods in the contract and not clearing is better for the constructor? |
right ;) |
not really but we were discussing that point during a call a few weeks/month ago |
I think there's a bug filed from an user for that (can't find the issue though), and after having tried a bit last week function / constructor execution, i think that more convenient to not clear the input. The main reason is that you often need to test the same function and you need to be able to easily copy/paste the inputs. I think the better would be to be able to have some sort of autocompletion e.g a way to easily retrieve the inputs, so not clearing is like a "work around" for now. |
Everything looks fine - except the i seems a bit big - probably it should not have the font-size specified - as I had suggested when it was a ?. Its a very tiny detail though. We can proceed with or without this change. |
1 more comment - the spacing between the Deploy button and the or and then between the or and the AtAddress button is not the same. The Ataddress needs to have a margin-top of 6px - I think. |