Refactor debugger - extract logic from views, move to separate module #1543

iurimatias · 2018-10-04T20:42:41Z

next steps:

move src/app/debugger/debugger to the remix-debug
refactor further code in src/app/debugger/debugger (logic extracted)
abstract execution context so it accepts a web3 object and builds the execution context inside the remix debug itself

yann300 · 2018-10-10T13:52:31Z

src/app/debugger/debugger/VmDebugger.js

+        storageViewer.storageRange(function (error, result) {
+          if (!error) {
+            storageJSON[address] = result
+            self.event.trigger('traceLengthUpdate', [storageJSON])


I think that should be storageAddressesUpdate

… false

…lues

…r callback of the step manager stepChanged event

…r from the UI

iurimatias requested a review from yann300 October 4, 2018 20:45

iurimatias force-pushed the refactor_debugger branch from 055eb12 to c18e3fe Compare October 5, 2018 23:21

yann300 force-pushed the refactor_debugger branch from 0b5917b to 4ba44e5 Compare October 10, 2018 09:14

yann300 reviewed Oct 10, 2018

View reviewed changes

iurimatias added 26 commits November 13, 2018 17:59

move debugger UI to its own module

afac37e

move active events

80ea6c5

create event for debugger state; add debug method

faab2ff

move provider set into debugger class

f59d81b

remove unused code

d81d67d

fix typo

91bfaab

remove unused code

e1db94a

move debugger UI; out of debugger class

7ed15a1

remove unused code

ef087ec

remove unused parameters

5fdf5b0

use new tx browser; move code to upper class

abae083

remove unused code

5a1291e

remove unused code

2caaaf4

cleanup

a3e1148

remove all code related to displayConnectionSetting since it's always…

04de04d

… false

move provider change event out of tx browser; simplify set default va…

b9050ba

…lues

cleanup

bea5df4

clean up; remove unnecessary else's

0fd02d6

remove local variable not used anywhere

c949aec

simplify update method

b5d849c

move logic out of txbrowser ui into parent

d79705e

cleanup

a47d7e8

add new stepmanager and related files; move step manager out of old ui

9546b78

remove unused method

1f254fb

remove unused parameter

7e3df36

remove unused variable

860735b

iurimatias and others added 23 commits November 13, 2018 18:17

remove debugger UI dependency out of solidityLocals

1cd738d

update references to parent debugger

cdbd711

completly remove debuggerUI reference dependency

54dd28d

remove commented out code

2f1539c

remove unused events

944ced1

remove unused events

2d85ad1

remove unnecessary event

2a0b6c7

remove extra step update which turned to be redudant

ec9b151

refactor: remove redudant extra indexChange event and move logic unde…

1712cf6

…r callback of the step manager stepChanged event

move step manager step changed response to debugger

143ffa6

move getTx to debugger logic

683fa62

move trace loading check from ui to debugger

b9a0699

refactor; simplify old debug method

f69e6b2

move breakpoint event from ui to debugger

8cd4a35

refactor unload; remove all direct references to the internal debugge…

75f8b3a

…r from the UI

rename transactionDebugger to just debugger

a65d8d1

make linter happy

a3a979a

remove old remix-debugger circle task

b4e0e03

add missing new param to offsetToLineColumn

92ea82d

fix Renaming

f21fc1e

fix: switch provider

efe53ad

fix full storage changes

4afd5e6

fix debugging with source location

3ef2e63

yann300 force-pushed the refactor_debugger branch from d12496b to 3ef2e63 Compare November 14, 2018 09:50

yann300 added 3 commits November 14, 2018 10:53

typo

2571d05

try fixing tests

703e901

circle-ci cache

72fe39c

yann300 approved these changes Nov 14, 2018

View reviewed changes

yann300 merged commit 783ac30 into master Nov 14, 2018

iurimatias deleted the refactor_debugger branch January 17, 2019 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor debugger - extract logic from views, move to separate module #1543

Refactor debugger - extract logic from views, move to separate module #1543

iurimatias commented Oct 4, 2018 •

edited

Loading

yann300 Oct 10, 2018

Refactor debugger - extract logic from views, move to separate module #1543

Refactor debugger - extract logic from views, move to separate module #1543

Conversation

iurimatias commented Oct 4, 2018 • edited Loading

yann300 Oct 10, 2018

Choose a reason for hiding this comment

iurimatias commented Oct 4, 2018 •

edited

Loading