Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract metadata #1551

Merged
merged 9 commits into from
Oct 18, 2018
Merged

Contract metadata #1551

merged 9 commits into from
Oct 18, 2018

Conversation

yann300
Copy link
Collaborator

@yann300 yann300 commented Oct 15, 2018

  • add .abi & .data.json
  • rename .json => .deploy.json

@yann300
add <contractname>.abi & <contractname>.data.json
09debef 
rename <contractname>.json => <contractname>.deploy.json
@yann300 yann300 requested a review from ryestew October 15, 2018 13:05
@ryestew
Copy link
Collaborator

ryestew commented Oct 17, 2018 •
edited
Loading

@yann300 - Its much better with all the data rolled into 1 file.
This comment might be out of scope of this PR but would changing the color of a json file in the file explorer be an option? Or at least an auto generated json file:

image

Also I'd prefer if the .json file came after the .sol file - but that would screw up the alphabetizing of the list. Too bad j comes before s.

@yann300 yann300 merged commit b8514e7 into master Oct 18, 2018
@axic axic deleted the addNewCompilationMetadata branch November 14, 2018 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryestew ryestew Awaiting requested review from ryestew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yann300 @ryestew