setFile #2128
Merged
setFile #2128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LianaHus
changed the title
GrandSchtroumpf
suggested changes
Jul 1, 2019
| </div>` | ||
| return yo` | ||
| <div class="container ml-1"> | ||
| <button class="btn btn-primary btn-sm m-1" onclick=${(e) => { |
There was a problem hiding this comment.
Create a closure (local function) instead of writing the function inside the onclick tag
| <div class="container ml-1"> | ||
| <button class="btn btn-primary btn-sm m-1" onclick=${(e) => { | ||
| reject = false | ||
| e.target.innerHTML = 'Accepted' |
There was a problem hiding this comment.
I think we should try to adopt a reactive way of programming if possible. In this case you would create a variable accepted, and call yo.update. Don't change it inside this PR, I'll create an issue for that.
| }}> | ||
| Accept | ||
| </button> | ||
| <button class="btn btn-primary btn-sm m-1" onclick=${(e) => { |
There was a problem hiding this comment.
Same here, create a closure.
| }}> | ||
| Cancel | ||
| </button> | ||
| <button class="btn btn-primary btn-sm m-1" onclick=${(e) => { |
GrandSchtroumpf
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/ethereum/remix-ide/issues/2106