fixed swapPanel height #2180
Merged
fixed swapPanel height #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,8 +31,9 @@ const css = csjs` | |||
| cursor: pointer; | |||
| } | |||
| .pluginsContainer { | |||
| height: calc(100% - 35px); | |||
| overflow: auto; | |||
| height: 100%; | |||
There was a problem hiding this comment.
remove height here. flex: 1 should be enough.
| overflow: auto; | ||
| height: 100%; | ||
| flex: 1; | ||
| padding-bottom: 40px; |
There was a problem hiding this comment.
because otherwise the top is shifted when it's not an iframe
src/app/components/side-panel.js
Outdated
| @@ -5,7 +5,9 @@ const yo = require('yo-yo') | |||
| const css = csjs` | |||
| .panel { | |||
| height: 100%; | |||
| overflow-y: hidden; | |||
| overflow-y: hidden; | |||
There was a problem hiding this comment.
remove this. There is no reason to hide it now.
LianaHus
force-pushed
the
swapPanelHeight
branch
from
53f8a57
to
8877ed5
Compare
LianaHus
force-pushed
the
swapPanelHeight
branch
from
8877ed5
to
f1c3a03
Compare
GrandSchtroumpf
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.