add the debug plugin #2232
add the debug plugin #2232
Conversation
Hello ! I made this PR to add my debug plugin, it will help plugin devs debugging their plugins, and remix devs testing the plugin-api ! Also sources are available [here](https://github.com/pldespaigne/remix-debug-plugin) if you want to have a look.
| version: '0.1.0-alpha', | ||
| url: 'https://remix-debug-a.surge.sh', | ||
| icon: 'https://remix-debug-a.surge.sh/icon.png', | ||
| location: 'sidePanel' |
There was a problem hiding this comment.
Wouldn't it be better in the mainpanel ? As most of the plugins are inside the sidepanel, you can have both of them on the same page.
There was a problem hiding this comment.
That make sense ! I will test the ui in the main panel then
| events: [], | ||
| version: '0.1.0-alpha', | ||
| url: 'https://remix-debug-a.surge.sh', | ||
| icon: 'https://remix-debug-a.surge.sh/icon.png', |
There was a problem hiding this comment.
we use a very similar icon for our native Debug plugin. both will be shown on Vertical panel when activated.
There was a problem hiding this comment.
Yeah I wasn't sure about my icon, I try to mix the debug icon with the plugin manager icon, I can change that without changing the icon's url. Also I'm open to any icon suggestion
There was a problem hiding this comment.
https://fontawesome.com/icons/spider?style=solid ? :) I'm not sure either, but it should be different
There was a problem hiding this comment.
I'll do it this evening
There was a problem hiding this comment.
Hi ! I have changed the icon, what do you think now ?
|
@pldespaigne could you please resolve the conflict so we can merge? |
Hello ! I made this PR to add my debug plugin, it will help plugin devs debugging their plugins, and remix devs testing the plugin-api !
Also sources are available here if you want to have a look.