side panel resize #2270
Merged
side panel resize #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrandSchtroumpf
approved these changes
Aug 19, 2019
| @@ -157,22 +156,25 @@ class App { | |||
|
|
|||
| // center panel, resizable | |||
| self._view.sidepanel = yo` | |||
| <div id="side-panel" class=${css.sidepanel}> | |||
| <div id="side-panel" style="min-width: 320px;" class=${css.sidepanel}> | |||
There was a problem hiding this comment.
Set the min-width in CSS. Don't set style inline except if you're modifing it with Javascript.
There was a problem hiding this comment.
this is done in purpose, I had to do this so I can use in Panel-resize.
src/lib/panels-resize.js
Outdated
| this.opt = opt | ||
| constructor (panel) { | ||
| this.panel = panel | ||
| let self = this |
src/lib/panels-resize.js
Outdated
| let self = this | ||
| const string = panel.style.minWidth | ||
| this.minWidth = string.length > 2 ? parseInt(string.substring(0, string.length - 2)) : 0 | ||
| window.addEventListener('resize', function (event) { |
There was a problem hiding this comment.
Use arrow function to have acces to this:
window.addEventListener('resize', (event) => this.setPosition(event))
src/lib/panels-resize.js
Outdated
|
|
||
| var ghostbar = yo`<div class=${css.ghostbar}></div>` | ||
| render () { | ||
| this.ghostbar = yo`<div class=${css.ghostbar}></div>` | ||
|
|
||
| let mousedown = (event) => { |
src/lib/panels-resize.js
Outdated
| @@ -51,58 +47,47 @@ export default class PanelsResize { | |||
|
|
|||
| let cancelGhostbar = (event) => { | |||
src/lib/panels-resize.js
Outdated
| panel1.style.width = p.panel1Width + 'px' | ||
| panel2.style.left = p.panel2left + 'px' | ||
| panel2.style.width = p.panel2Width + 'px' | ||
| let moveGhostbar = (event) => { |
src/lib/panels-resize.js
Outdated
|
|
||
| setPosition(opt) | ||
| setPosition (event) { | ||
| let panelWidth = this.calculatePanelWidth(event) |
There was a problem hiding this comment.
If you don't reasign this value, use const
| @@ -17,10 +17,10 @@ function checkFilter (browser, filter, test, done) { | |||
| done() | |||
| return | |||
| } | |||
| var filterClass = '#editor-container div[class^="search"] input[class^="filter"]' | |||
| var filterClass = '#main-panel div[class^="search"] input[class^="filter"]' | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.