Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor file explorer #2348

Merged
merged 1 commit into from
Sep 23, 2019
Merged

Refactor file explorer #2348

merged 1 commit into from
Sep 23, 2019

Conversation

yann300
Copy link
Collaborator

@yann300 yann300 commented Sep 19, 2019

No description provided.

@@ -525,7 +525,7 @@ fileExplorer.prototype.updateGist = function () {

fileExplorer.prototype.createNewFile = function () {
let self = this
modalDialogCustom.prompt('Create new file', 'File Name', 'Untitled.sol', (input) => {
modalDialogCustom.prompt('Create new file', 'File Path (Untitled.sol, Folder1/Untitled.sol1)', 'Untitled.sol', (input) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo sol1?

@yann300 yann300 force-pushed the only_browser_explorer branch 8 times, most recently from 944e66a to 4b370a9 Compare September 19, 2019 13:34
Copy link
Collaborator

@LianaHus LianaHus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break some features in alpha. should not be merged to live without fixing those.
https://demo.hackmd.io/HwZBULtNTOeq5vkoQQDbVA?both

@yann300 yann300 merged commit 2ee99e7 into master Sep 23, 2019
@yann300 yann300 deleted the only_browser_explorer branch September 29, 2019 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants