Various Fixes File explorer #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
LianaHus
commented
Sep 23, 2019
•
LianaHus
commented
- fixes import with github, http,resolver-engine
- fixes tooltip for publish to gist
- add readonly mode(is not finished yet)
yann300
reviewed
Sep 23, 2019
src/app/files/file-explorer.js
Outdated
| @@ -350,7 +350,7 @@ fileExplorer.prototype.init = function () { | |||
| fileExplorer.prototype.publishToGist = function () { | |||
| modalDialogCustom.confirm( | |||
| 'Create a public gist', | |||
| 'Are you sure you want to publish all your files anonymously as a public gist on github.com?', | |||
| 'Are you sure you want to publish all your files in browser directory anonymously as a public gist on github.com?', | |||
There was a problem hiding this comment.
we should say that this will not include folder
There was a problem hiding this comment.
I would say it's fine. we would implement this anyway, oder?
Wouldn't this be too long with folder stuff?
There was a problem hiding this comment.
well I don't really think we can implement that easily, gists does not support having folder.
Your sentence is ok but it should explicitly state that folders are not uploaded
yann300
reviewed
Sep 23, 2019
src/app/files/fileProvider.js
Outdated
| addReadOnly (path, content) { | ||
| addReadOnly (path, content, url) { | ||
| this.readonlyItems.push(path) | ||
| if (url !== undefined) this.normalizedNames[url] = path |
yann300
reviewed
Sep 23, 2019
src/app/files/fileProvider.js
Outdated
| @@ -63,15 +66,23 @@ class FileProvider { | |||
| return true | |||
| } | |||
|
|
|||
| addReadOnly (path, content) { | |||
| addReadOnly (path, content, url) { | |||
| this.readonlyItems.push(path) | |||
There was a problem hiding this comment.
we should keep this in the local storage. Perhaps by having a .remix-system file.
There was a problem hiding this comment.
yes, let it be a separate PR
yann300
reviewed
Sep 23, 2019
src/app/files/fileProvider.js
Outdated
| return this.set(path, content) | ||
| } | ||
|
|
||
| isReadOnly (path) { | ||
| return false | ||
| return !this.readonlyItems.includes(path) |
There was a problem hiding this comment.
return this.readonlyItems.includes(path) ?
- fixes tooltip for publish to gist - add readonly mode(is not finished yet)
standard
yann300
approved these changes
Sep 24, 2019
yann300
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.