refactor, abstract and remove dependencies on executionContext and udapp #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iurimatias
commented
Jan 7, 2020
•
iurimatias
commented
- remove dependency on executionContext
- remove duplicated code
- misc refactors
- remove blockchain connectionn specific logic from udapp-ui, make it just ui
iurimatias
changed the title
iurimatias
requested review from
yann300,
GrandSchtroumpf,
Aniket-Engg and
LianaHus
…d of txlistener" This reverts commit c2d7422.
iurimatias
force-pushed
the
refactor_logic4
branch
from
b69fbce
to
fd2bd33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.