Receive bug and more tests #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
reviewed
Jan 30, 2020
src/app/ui/universal-dapp-ui.js
Outdated
| @@ -161,7 +161,7 @@ UniversalDAppUI.prototype.renderInstanceFromABI = function (contractABI, address | |||
| const fallback = self.udapp.getFallbackInterface(contractABI) | |||
| const receive = self.udapp.getReceiveInterface(contractABI) | |||
| const args = { | |||
| funABI: fallback, | |||
| funABI: (fallback ? fallback : receive), | |||
There was a problem hiding this comment.
then it's fine. fallback is default one
yann300
reviewed
Jan 30, 2020
src/app/ui/universal-dapp-ui.js
Outdated
| @@ -177,16 +177,22 @@ UniversalDAppUI.prototype.renderInstanceFromABI = function (contractABI, address | |||
| } | |||
| } | |||
| if (calldata) { | |||
| if (calldata.length > 3 && calldata.substr(0, 2) === '0x') { | |||
| if (calldata.length < 2) setLLIError('the calldata should be a valid hexadecimal value with size of at least one byte.') | |||
| if (calldata.length < 4 && calldata.substr(0, 2) === '0x') { | |||
There was a problem hiding this comment.
this is more than that, the size should be even
LianaHus
commented
Jan 30, 2020
src/app/ui/universal-dapp-ui.js
Outdated
| // if receive is defined and that there is no calldata => receive function is called | ||
| // if fallback is defined => fallback function is called | ||
| if (receive && !calldata) args.funABI = receive | ||
| if (fallback) args.funABI = fallback |
There was a problem hiding this comment.
this will rewrite your previous change
yann300
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.