Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating docs with about Low level interactions with a contract #2574

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

ryestew
Copy link
Collaborator

@ryestew ryestew commented Feb 4, 2020

No description provided.

docs/udapp.md Outdated

- If you are not sending ether to the contract but **are** sending call data then you need to use the fallback() function.

- If you break the rules when using the **Low level interactions** you will be slapped with a warning.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this line

docs/udapp.md Outdated

- If you break the rules when using the **Low level interactions** you will be slapped with a warning.

Please see the [solidity docs](https://solidity.readthedocs.io/en/v0.6.2/contracts.html#receive-ether-function) for more specifics about using the **fallback** and **receive** functions.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its better to use same version link in all solidity links including above ones : https://solidity.readthedocs.io/en/latest/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryestew could you update that URL?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be OK to have a link to both the root of the solidity docs ( like the one you are suggesting and also to have a like to the specific issue here - which is about receive() & fallback() or is it better to just to have to link to the Solidity docs and have the reader find the appropriate section on their own?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also on line 27 (of udapp.md) there is a link to another specific part of the solidity docs - the modifiers section. What is the advantage of not pointing people to a specific part of the solidity docs?

@yann300 yann300 merged commit 12039f0 into master Feb 6, 2020
@yann300 yann300 deleted the docs-udapp-fb-rec branch February 6, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants