Splash screen #2605
Merged
Splash screen #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
splashScreen
branch
from
f818c45
to
3ccc3e5
Compare
yann300
force-pushed
the
splashScreen
branch
from
3ccc3e5
to
5cc88e4
Compare
yann300
force-pushed
the
splashScreen
branch
from
840d83d
to
a4db1dd
Compare
ryestew
requested changes
Feb 17, 2020
src/app.js
Outdated
| @@ -98,12 +98,38 @@ var css = csjs` | |||
| background-color : var(--info); | |||
| opacity : 0.5; | |||
| } | |||
| .centered { | |||
| position : fixed; | |||
| top : 50%; | |||
There was a problem hiding this comment.
When I put:
top: 20%;
left: 30%;
The logo was a bit easier to see. I'd recommend at least using the top:20%. The left: 30% is less important.
yann300
force-pushed
the
splashScreen
branch
from
ad0b237
to
eaf50fe
Compare
ioedeveloper
approved these changes
Feb 17, 2020
Merged
yann300
force-pushed
the
splashScreen
branch
from
d26605b
to
da5f754
Compare
ryestew
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a splash screen in order to avoid all the glitches when the app starts.