Web3 Provider modal for local devmode #2688
Conversation
|
Can be merged - pending approval ( of course) |
ryestew
force-pushed
the
web3Provides
branch
4 times, most recently
from
390f23c
to
a24dfd7
Compare
src/app/tabs/runTab/settings.js
Outdated
| <div class="border p-1">geth --rpc --rpccorsdomain https://remix.ethereum.org</div> | ||
| <br> | ||
| To run Remix locally & a local Geth test node, use this command: (see <a href="https://geth.ethereum.org/getting-started/dev-mode" target="_blank">Geth Docs on Dev mode</a>) | ||
| <div class="border p-1">geth --rpc --rpccorsdomain="package://a7df6d3c223593f3550b35e90d7b0b1f.mod" --rpcapi web3,eth,debug,personal,net --vmdebug --datadir ${thePath} --dev console</div> |
There was a problem hiding this comment.
instead of package://a7df6d3c223593f3550b35e90d7b0b1f.mod you should print window.origin
There was a problem hiding this comment.
that will use the current origin of the page
There was a problem hiding this comment.
When running locally this will become http://localhost:8080 instead of package://a7df6d3c223593f3550b35e90d7b0b1f.mod - it does work successfully like that. The problem with this approach is that when this is on remix-alpha, the command will have that URL in it - so you won't be running it locally. If that is OK - then we should change the line above so it is not specifying running a local version of Remix. Thus making it:
To run Remix & a local Geth test node ...
There was a problem hiding this comment.
ah right, so we don't need to specify locally for remix
fixes https://github.com/ethereum/remix-ide/issues/2669