improve compiler api #2876
Merged
improve compiler api #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yann300
force-pushed
the
compilerAPI
branch
4 times, most recently
from
39b98a4
to
992a63d
Compare
LianaHus
reviewed
Jun 9, 2020
| @@ -32,6 +32,10 @@ module.exports = class CompilerArtefacts extends Plugin { | |||
| this.on('lexon', 'compilationFinished', (file, source, languageVersion, data) => { | |||
| this.compilersArtefacts['__last'] = new CompilerAbstract(languageVersion, data, source) | |||
| }) | |||
|
|
|||
| this.on('yupl', 'compilationFinished', (file, source, languageVersion, data) => { | |||
There was a problem hiding this comment.
LianaHus
reviewed
Jun 9, 2020
src/app/tabs/compile-tab.js
Outdated
| this.compilerContainer.setLanguage(settings.language) | ||
| this.compilerContainer.setEvmVersion(settings.evmVersion) | ||
| this.compilerContainer.setOptimize(settings.optimize) | ||
| this.compilerContainer.setVersion(settings.version) |
There was a problem hiding this comment.
sould maybe compilerContainer has setSettings?
There was a problem hiding this comment.
yes sure, the thing is that these methods were already existing before
LianaHus
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/ethereum/remix-ide/issues/2712
partly_fix https://github.com/ethereum/remix-ide/issues/2854
compileWithParametersandsetCompilerConfigplugin API