Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Txlistener reads on the last compilation per file and not only the last one #2898

Merged
merged 6 commits into from
Jun 29, 2020

Conversation

yann300
Copy link
Collaborator

@yann300 yann300 commented Jun 11, 2020

fix #2864

@yann300 yann300 requested a review from LianaHus June 11, 2020 12:43
@yann300 yann300 force-pushed the fix#2864 branch 3 times, most recently from 904a9dc to 4628ece Compare June 17, 2020 09:28
@yann300 yann300 force-pushed the fix#2864 branch 3 times, most recently from fd9e1f8 to 2507c8f Compare June 27, 2020 19:44
})
// making sure we shave last compilation result in there
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@@ -72,7 +72,7 @@ export default class FetchAndCompile extends Plugin {
name === 'main' ? 'mainnet' : name // source-verifier api expect "mainnet" and not "main"
let data
try {
data = await this.call('source-verification', 'fetchByNetwork', contractAddress, name.toLowerCase())
data = await this.call('sourcify', 'fetchByNetwork', contractAddress, name.toLowerCase())
Copy link
Collaborator

@LianaHus LianaHus Jun 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you do this in this PR please also change it on homepage UI and loading page code

@yann300 yann300 merged commit 491a323 into master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remix v.0.10.1 'Deploy & Run' transacts to incorrect function in VM
3 participants