Skip to content
This repository has been archived by the owner on Mar 3, 2021. It is now read-only.

Improve fetching compilation result #1456

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Improve fetching compilation result #1456

merged 2 commits into from
Apr 22, 2020

Conversation

yann300
Copy link
Collaborator

@yann300 yann300 commented Apr 22, 2020

linked to ethereum/remix-ide#2755

This PR:

  • Turn the property compilationResult into an async callback.
  • improve testing bytecode match.

@yann300 yann300 changed the title Improve fetching compilation result WIP Improve fetching compilation result Apr 22, 2020
@yann300 yann300 added the WIP Work In Progress label Apr 22, 2020
@yann300 yann300 changed the title WIP Improve fetching compilation result Improve fetching compilation result Apr 22, 2020
@yann300 yann300 mentioned this pull request Apr 22, 2020
Merged
@yann300 yann300 force-pushed the improveFetchingCompilationResult branch from 1b37e36 to 76dc7db Compare April 22, 2020 11:26
@yann300 yann300 force-pushed the improveFetchingCompilationResult branch from 76dc7db to 5331ab7 Compare April 22, 2020 14:20
@yann300 yann300 force-pushed the improveFetchingCompilationResult branch from 5331ab7 to d7b71e5 Compare April 22, 2020 14:22
@yann300 yann300 removed the WIP Work In Progress label Apr 22, 2020
@yann300 yann300 merged commit af1be32 into master Apr 22, 2020
@yann300 yann300 deleted the improveFetchingCompilationResult branch April 22, 2020 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Aniket-Engg Aniket-Engg Aniket-Engg approved these changes

@ioedeveloper ioedeveloper Awaiting requested review from ioedeveloper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yann300 @Aniket-Engg