Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make soljson.js a symlink again #110

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

cameel
Copy link
Member

@cameel cameel commented Feb 3, 2022

#99 replaced soljson.js at the root of the repository (which as a symlink) with an actual binary. This is wrong because this way the file is not getting updated when we publish a release (the update script ignores it on purpose assuming it's a symlink).

This PR fixes this by restoring the symlink.

- It's not being updated by the `update` script and is at 0.8.9 now. It should have been a symlink all along.
@cameel cameel self-assigned this Feb 3, 2022
@cameel
Copy link
Member Author

cameel commented Feb 3, 2022

We should also consider retrying #33 and #39. Now that we are getting binaries from S3 and not from GH pages, I think that symlinks would work just fine because we convert them into copies on the server.

@cameel cameel merged commit 5029965 into gh-pages Mar 7, 2022
@cameel cameel deleted the turn-root-soljson-js-back-into-a-symlink branch March 7, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants