Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic sort order for nightlies #37

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Deterministic sort order for nightlies #37

merged 1 commit into from
Jul 13, 2020

Conversation

cameel
Copy link
Member

@cameel cameel commented Jul 9, 2020

Part of ethereum/solidity#9258. Related to #30 (comment).

Semantic Versioning 2.0.0 > bullet point 10

Build metadata MUST be ignored when determining version precedence. Thus two versions that differ only in the build metadata, have the same precedence. Examples: 1.0.0-alpha+001, 1.0.0+20130313144700, 1.0.0-beta+exp.sha.5114f85, 1.0.0+21AF26D3—-117B344092BD.

So e.g. 0.4.2-nightly.2016.9.17+commit.212e0160 is treated as equal to v0.4.2-nightly.2016.9.17+commit.a78e7794. We have to add an extra commit hash comparison if we want the order to be stable.

This PR solves the same problem as #36 but also ensures that it won't happen again. I think we should merge both.

@cameel cameel requested review from ekpyron and chriseth July 9, 2020 21:10
@cameel cameel self-assigned this Jul 9, 2020
cameel
cameel commented Jul 9, 2020
View reviewed changes
update Outdated Show resolved Hide resolved
@cameel cameel force-pushed the deterministic-sort-order-for-nightlies branch from 302c9ef to 8f96f7f Compare July 9, 2020 21:20
@chriseth
Copy link
Contributor

Looks good!

@cameel cameel force-pushed the deterministic-sort-order-for-nightlies branch from 8f96f7f to 821b2ba Compare July 13, 2020 11:50
@cameel
Copy link
Member Author

cameel commented Jul 13, 2020

Rebased on the merged #36. Changes to lists are gone now because the only affected nightlies were removed.

@chriseth chriseth merged commit faf85e9 into gh-pages Jul 13, 2020
@cameel cameel deleted the deterministic-sort-order-for-nightlies branch July 17, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriseth chriseth chriseth approved these changes

@ekpyron ekpyron Awaiting requested review from ekpyron

Assignees

@cameel cameel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameel @chriseth