Drop require-from-string to restore Webpack compatibility #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576.
require-from-stringis a tiny package and we're even not using all of its features. It's also no longer maintained because floatdrop/require-from-string#18 is has not been fixed since 2018. This PR replaces it with a few lines of code and drops the dependency.The real question is how do we test this properly? It passes our current tests but the problem exists only on Webpack.
Also, the author or the PR that broke Webpack compatibility claims that Webpack does not even provide
module(floatdrop/require-from-string#6 (comment)). Not sure how to verify that.