TemporaryWorkingDirectory helper #11385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cameel
commented
May 12, 2021
| /** | ||
| * An object that changes current working directory and restores it upon destruction. | ||
| */ | ||
| class TemporaryWorkingDirectory |
There was a problem hiding this comment.
I put the class in TemporaryDirectory.h which already contains a similar helper but maybe I should create a separate TemporaryWorkingDirectory.h instead?
There was a problem hiding this comment.
If we have such a granular separation in the test directory, then yes, otherwise I think it is fine.
cameel
force-pushed
the
temporary-working-directory-helper
branch
from
4415682 to
bf431b0
Compare
cameel
force-pushed
the
temporary-working-directory-helper
branch
from
f286252 to
4a2080b
Compare
|
I solved the CI problems so this is now ready for review. The issue was that the path to a tmp dir I was receiving on macOS was through a symlink. I was using that path to change directory but then, upon asking what the current directory is I was getting canonical path and the comparison in a test was failing. Switching to |
axic
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #11384. Marked as draft until the dependency gets merged.
This PR adds a very simple
TemporaryWorkingDirectorytest helper that lets you change working directory in a test without risking the change being permanent and affecting other tests. If your test crashes, the object ensures upon destruction that the directory gets changed back.