More pop removal in peephole optimizer. #12795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't seem to add much on top of #12759 for the external test benchmarks: bleeps
ir-optimize-evm+yul
bytecode_size : -0.02 %
method_gas : 0.00 %
elementfi
ir-optimize-evm+yul
bytecode_size : -0.01 %
deployment_gas : -0.01 %
method_gas : 0.01 %
ens
ir-optimize-evm+yul
bytecode_size : -0.09 %
deployment_gas : -0.07 %
method_gas : 0.00 %
gnosis
ir-optimize-evm+yul
bytecode_size : -0.06 %
deployment_gas : -0.13 %
method_gas : -0.00 %
pool-together
ir-optimize-evm+yul
bytecode_size : -0.02 %
deployment_gas : -0.02 %
method_gas : -0.00 %
prb-math
ir-optimize-evm+yul
bytecode_size : 0.00 %
deployment_gas : -0.00 %
trident
ir-optimize-evm+yul
bytecode_size : -0.05 %
deployment_gas : -0.03 %
method_gas : -0.02 %
yield_liquidator
ir-optimize-evm+yul
bytecode_size : -0.02 %
deployment_gas : -0.04 %
method_gas : 0.00 %
zeppelin
ir-optimize-evm+yul
bytecode_size : -0.07 %
deployment_gas : -0.07 %
method_gas : -0.00 %
|
ekpyron
added
the
has dependencies
chriseth
reviewed
Mar 15, 2022
ekpyron
force-pushed
the
evmCodeTransformAvoidPops
branch
from
faaf0b9
to
5cd9800
Compare
ekpyron
force-pushed
the
morePopRemovalInPeepholeOptimizer
branch
from
c57c5ad
to
60fa8db
Compare
ekpyron
removed
the
has dependencies
…tructions before simple terminations.
ekpyron
force-pushed
the
morePopRemovalInPeepholeOptimizer
branch
from
60fa8db
to
4b9c017
Compare
chriseth
reviewed
Mar 17, 2022
| std::back_insert_iterator<AssemblyItems> _out | ||
| ) | ||
| { | ||
| if ( |
There was a problem hiding this comment.
This mechanism could even be extended more:
We have op1, op2, op3, returnRevert where:
- op1 is side-effect free
- op2.args == 0, op2.return >= 1
- op3.args <= op2.return
- (op2.return + op3.return) - (op2.args + op3.args) >= 2
- returnRevert is return or revert
chriseth
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12759