Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce EVM version prague #15152

Merged
merged 1 commit into from
May 29, 2024
Merged

Introduce EVM version prague #15152

merged 1 commit into from
May 29, 2024

Conversation

matheusaaguiar
Copy link
Collaborator

closes #15111.

@matheusaaguiar matheusaaguiar self-assigned this May 27, 2024
cameel
cameel reviewed May 27, 2024
View reviewed changes
Copy link
Member

@cameel cameel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing in two places:

  • List of EVM versions in "Using the compiler".
    • Also the evmVersion field there has a comment with possible values.
  • test/tools/fuzzer_common.cpp, test/tools/ossfuzz/yulProto.proto and test/tools/ossfuzz/protoToYul.cpp (unless we're leaving it up to @bshastry)

liblangutil/EVMVersion.h Outdated Show resolved Hide resolved
cameel
cameel reviewed May 27, 2024
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
@nikola-matic
Copy link
Collaborator

Still missing in two places:

* List of EVM versions in "Using the compiler".
  
  * Also the `evmVersion` field there has a comment with possible values.

* `test/tools/fuzzer_common.cpp`, `test/tools/ossfuzz/yulProto.proto` and `test/tools/ossfuzz/protoToYul.cpp` (unless we're leaving it up to @bshastry)

@bshastry typically handles this on the fuzzer side.

@cameel
Copy link
Member

cameel commented May 27, 2024 •
edited
Loading

@bshastry typically handles this on the fuzzer side.

True, but these are simple enough that it would not hurt if we already added them here. But anyway, mentioning it mostly for completeness.

@matheusaaguiar matheusaaguiar force-pushed the introduce-evm-version-prague branch from 9aa33c8 to 11eebaa Compare May 28, 2024 14:04
r0qs
r0qs previously approved these changes May 28, 2024
View reviewed changes
cameel
cameel reviewed May 28, 2024
View reviewed changes
docs/using-the-compiler.rst Outdated Show resolved Hide resolved
@cameel
Copy link
Member

cameel commented May 28, 2024

Needs squashing and then it's fine to merge.

@matheusaaguiar matheusaaguiar force-pushed the introduce-evm-version-prague branch from 562dd6b to 85396f4 Compare May 28, 2024 15:27
@nikola-matic nikola-matic merged commit d97059c into develop May 29, 2024
71 of 72 checks passed
@nikola-matic nikola-matic deleted the introduce-evm-version-prague branch May 29, 2024 05:55
@fgimenez fgimenez mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikola-matic nikola-matic nikola-matic approved these changes

@cameel cameel cameel approved these changes

@r0qs r0qs r0qs left review comments

Assignees

@matheusaaguiar matheusaaguiar

Labels
None yet
Projects
Solidity Focus Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add EVM Version Prague
4 participants
@matheusaaguiar @nikola-matic @cameel @r0qs